fix: VSCode desktop connection #7120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Nice find! We should probably add a unit test for this change though.
See here:
Line 1361 in 17f692a
We should probably also document this in docs/template/open-in-coder.md.
kylecarbs
approved these changes
Apr 13, 2023
mafredri
reviewed
Apr 14, 2023
mafredri
reviewed
Apr 14, 2023
Co-authored-by: Mathias Fredriksson <[email protected]>
johnstcn
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with VS Code Desktop connection when the URI becomes invalid if the
dirincoder_agentresource is not an absolute path or does not start with~.Fixes coder/vscode-coder#80