Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: report failed CompletedJob #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 6, 2023
Merged

fix: report failed CompletedJob #8318

merged 7 commits into from
Jul 6, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 5, 2023 •
edited
Loading

Fixes: #8048

This PR improves provisioner job handling by reporting failed CompletedJob. Currently, the CLI hangs as the provisioner job fails silently. Once the change is merged, CLI will fail with:

2023-07-05 10:48:26.924+02:00 Use context instead. This attribute will be removed in the next major release.
=== ✔ Detecting ephemeral resources [691ms]
==> ⧗ Cleaning Up
=== ✘ Cleaning Up [23ms]
=== ✘ Cleaning Up [35ms]
running command "coder templates push": internal provisionerserver error

Additionally, this PR modifies the ConvertState logic to detect duplicate coder_metadata resources.

@mtojek mtojek self-assigned this Jul 5, 2023
@mtojek mtojek changed the title fix: report failed CompletedJob with FailedJob fix: report failed CompletedJob Jul 5, 2023
@mtojek mtojek requested review from mafredri and johnstcn July 5, 2023 11:27
@mtojek mtojek marked this pull request as ready for review July 5, 2023 11:27
johnstcn
johnstcn approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, although the PR title could possibly be reworded as "detect duplicate metadata resources" as this is the bigger change here.

mafredri
mafredri approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnstcn had some good comments, only found some crumbs left over 😂

@mtojek mtojek enabled auto-merge (squash) July 6, 2023 07:24
@mtojek mtojek merged commit c6fcd7e into main Jul 6, 2023
@mtojek mtojek deleted the 8048-fail-completedjob branch July 6, 2023 07:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri mafredri approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace stuck on "cleaning up" when app slug is duplicate on template push
4 participants
@mtojek @mafredri @johnstcn @kylecarbs