Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: report failed CompletedJob #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2023
Merged

fix: report failed CompletedJob #8318

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
259ebf5
feat: report failed CompletedJob
mtojek Jul 5, 2023
9e8f81c
catch duplicate metadata resource
mtojek Jul 5, 2023
7bf2098
Test
mtojek Jul 5, 2023
1abd133
Fix
mtojek Jul 5, 2023
34b8d55
metadataTargetLabels
mtojek Jul 5, 2023
c0c71ff
Merge branch 'main' into 8048-fail-completedjob
mtojek Jul 5, 2023
a4848a7
Merge branch 'main' into 8048-fail-completedjob
mtojek Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
catch duplicate metadata resource
  • Loading branch information
@mtojek
mtojek committed Jul 5, 2023
commit 9e8f81c2b6da707cee4fa9c8646d18aacca67e8d
7 changes: 6 additions & 1 deletion provisioner/terraform/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ func ConvertState(modules []*tfjson.StateModule, rawGraph string) (*State, error
resourceIcon := map[string]string{}
resourceCost := map[string]int32{}

metadataTargetLabels := map[string]struct{}{}
for _, resources := range tfResourcesByLabel {
for _, resource := range resources {
if resource.Type != "coder_metadata" {
Expand All @@ -396,7 +397,6 @@ func ConvertState(modules []*tfjson.StateModule, rawGraph string) (*State, error
if err != nil {
return nil, xerrors.Errorf("decode metadata attributes: %w", err)
}

resourceLabel := convertAddressToLabel(resource.Address)

var attachedNode *gographviz.Node
Expand Down Expand Up @@ -433,6 +433,11 @@ func ConvertState(modules []*tfjson.StateModule, rawGraph string) (*State, error
}
targetLabel := attachedResource.Label

if _, ok := metadataTargetLabels[targetLabel]; ok {
return nil, xerrors.Errorf("duplicate metadata resource ID: %s", targetLabel)
}
metadataTargetLabels[targetLabel] = struct{}{}

resourceHidden[targetLabel] = attrs.Hide
resourceIcon[targetLabel] = attrs.Icon
resourceCost[targetLabel] = attrs.DailyCost
Expand Down