This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Add confirmation prompt to 'coder envs edit' #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawnsy
approved these changes
Mar 30, 2021
| @@ -430,6 +430,7 @@ func editEnvCmd() *cobra.Command { | |||
| gpus int | |||
| follow bool | |||
| user string | |||
| force bool | |||
internal/cmd/envs.go
Outdated
| @@ -482,6 +483,19 @@ coder envs edit back-end-env --disk 20`, | |||
| return err | |||
| } | |||
|
|
|||
| if !force && env.LatestStat.ContainerStatus == coder.EnvironmentOn { | |||
| _, err = (&promptui.Prompt{ | |||
| Label: fmt.Sprintf("Rebuild environment \"%s\"? (will destroy any work outside of /home)", env.Name), | |||
There was a problem hiding this comment.
it doesn't matter for anything, but fyi you can use %q to double quote your string (you can tell that I am extremely lazy)
Suggested change
| Label: fmt.Sprintf("Rebuild environment \"%s\"? (will destroy any work outside of /home)", env.Name), | |
| Label: fmt.Sprintf("Rebuild environment %q? (will destroy any work outside of /home)", env.Name), |
You might also want to mention "your home directory" instead of a specific path, because as a special case, root's home directory is /root
There was a problem hiding this comment.
I agree on "your home directory"
There was a problem hiding this comment.
Oh nice - didn't know about that %q 🤯 🙌
And yeah the rename from /home to your home directory is a good call. Fixed it on the rebuild prompt too 👌
| @@ -108,7 +108,7 @@ func Test_env_create(t *testing.T) { | |||
|
|
|||
| // edit the CPU of the environment | |||
| cpu = 2.1 | |||
| res = execute(t, nil, "envs", "edit", name, fmt.Sprintf("--cpu=%f", cpu), "--follow") | |||
| res = execute(t, nil, "envs", "edit", name, fmt.Sprintf("--cpu=%f", cpu), "--follow", "--force") | |||
There was a problem hiding this comment.
love that you added a test, TY ❤️
greyscaled
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CH9720 https://app.clubhouse.io/coder/story/9720/confirm-when-editing-environment-with-coder-cli