Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

estesp
Copy link
Member

@estesp estesp commented Aug 27, 2019

Only change is fixes for gRPC CVE issues by updating vendor to gRPC 1.23.0 release via PR #3586.

Signed-off-by: Phil Estes [email protected]

Preview draft of release notes: https://gist.github.com/estesp/8dfeab5baf156ea1dc92793043193167

@artch
Copy link

artch commented Aug 28, 2019

Is possible to include #3245 as well? Recently released GitHub Package Registry doesn't provide Docker-Content-Digest, and stable [email protected] cannot be used with it.

@thaJeztah
Copy link
Member

@artch I can open a backport for consideration by the maintainers; there's another ticket tracking issues with the GitHub Package Registry here: #3291 (so there may still be issues remaining)

/cc @Phanatic

@thaJeztah
Copy link
Member

Opened #3591 for consideration

@estesp estesp force-pushed the prep-v1.2.9 branch 2 times, most recently from 37049e3 to fdfddb3 Compare August 28, 2019 18:34
@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #3587 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #3587   +/-   ##
============================================
  Coverage        44.19%   44.19%           
============================================
  Files              100      100           
  Lines            10847    10847           
============================================
  Hits              4794     4794           
  Misses            5313     5313           
  Partials           740      740
Flag Coverage Δ
#linux 47.87% <ø> (ø) ⬆️
#windows 41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef0529...b3a8460. Read the comment docs.

@estesp estesp added this to the 1.2.9 milestone Sep 4, 2019
@estesp
Copy link
Member Author

estesp commented Sep 5, 2019

notes updated with all backports; gist notes preview updated (although missing the CRI vendor update as #3608 is not merged yet.)

Fixes gRPC CVE issues by updating vendor to gRPC 1.23.0 release.
Fix additional bugs via backport/cherry-pick and add to release notes.

Signed-off-by: Phil Estes <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan
Copy link
Member

dmcgowan commented Sep 5, 2019

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit d50db0a into containerd:release/1.2 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants