[WIP] Security changes (step 3) #1256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6469105 to
f507d62
Compare
leofeyer
reviewed
Dec 20, 2017
| private function checkIfAccountIsDisabled(User $user): void | ||
| { | ||
| if (false !== $user->isEnabled()) { | ||
| if (!$user->disable) { |
There was a problem hiding this comment.
What about (!$user->start || $user->start < $time) && (!$user->stop || $user->stop > $time)?
There was a problem hiding this comment.
That's already handled in e534341#diff-3965f81a275b864b36b992503eea7bd5R126, apparently because the log messages are different.
|
Since we cannot agree on how to implement ORM, let's just write our own token provider that uses |
4a366cd to
26cfc5b
Compare
|
I thought we're gonna discuss this tomorrow on the public Mumble call? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More things we should add to the new security implementation.
Tasks:
AdvancedUserInterface(see Deprecated the AdvancedUserInterface symfony/symfony#23508)Logout andlogin might not validate the CSRF token? logout is not a POST requesttl_prefixed tables in the install tool (see [WIP] Optionally handle tables without tl_ prefix installation-bundle#79)This PR is just an early draft for tasks and will be rebased once #1238 is merged.