Thanks to visit codestin.com
Credit goes to github.com

Skip to content

upgrade docker alpine image to alpine 3.17 #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tyranron merged 3 commits into from
Apr 12, 2023
Merged

upgrade docker alpine image to alpine 3.17 #1156

tyranron merged 3 commits into from
Apr 12, 2023

Conversation

@Zoey2936
Copy link
Contributor

@Zoey2936 Zoey2936 commented Feb 10, 2023 •
edited
Loading

I've tried building it with this change, and it worked without problem (required for nextcloud/all-in-one#1583)

@Zoey2936
upgrade docker alpine image to alpine 3.17
f75da3d 
I've tried building it with this change, and it worked without problem
@Zoey2936 Zoey2936 mentioned this pull request Feb 10, 2023
Merged
7 tasks
@eakraly eakraly requested a review from tyranron February 14, 2023 00:09
@eakraly
Copy link
Collaborator

eakraly commented Feb 14, 2023

Summoning @tyranron to weigh in
Unblocking review and builds for now

@Zoey2936
Copy link
Contributor Author

Zoey2936 commented Feb 14, 2023

Thanks!

@tyranron
Copy link
Collaborator

tyranron commented Feb 14, 2023

@Zoey2936 @eakraly I've already tried it before, it works OK for master branch, but doesn't build with 4.6.1 Coturn release, due to its issues with OpenSSL 3.x.

You may check this by trying make image dockerfile=alpine ref=4.6.1 command in docker/coturn/ dir.

We're blocked with Alpine 3.17 until master with fixed support of OpenSSL 3.x is released.

@tyranron tyranron added enhancement docker Docker image related labels Feb 14, 2023
@Zoey2936
Copy link
Contributor Author

Zoey2936 commented Feb 14, 2023

You may check this by trying make image dockerfile=alpine ref=4.6.1 command in docker/coturn/ dir.

I see...

@Zoey2936 Zoey2936 mentioned this pull request Feb 15, 2023
Closed
9 tasks
@eakraly
Copy link
Collaborator

eakraly commented Mar 5, 2023

@tyranron can we submit this change based on 4.6.1-r2 since it is tagged off latest master?

@tyranron
Copy link
Collaborator

tyranron commented Mar 7, 2023

@eakraly no. Despite it's tagged off latest master, it uses 4.6.1 Git tag to build Docker image from. We cannot have 3.17 unless we release latest master as new Coturn version.

@eakraly
Copy link
Collaborator

eakraly commented Mar 12, 2023

@ggarber Why don't we make 4.6.2 release then? 4.6.1 is broken wrt openssl-3.0...

@Zoey2936
Copy link
Contributor Author

Zoey2936 commented Mar 15, 2023

@ggarber Why don't we make 4.6.2 release then? 4.6.1 is broken wrt openssl-3.0...

If this is possible, it would be great to see!

@tyranron tyranron merged commit d5aa172 into coturn:master Apr 12, 2023
@tyranron
Copy link
Collaborator

tyranron commented Apr 12, 2023

@Zoey2936 @eakraly released in 4.6.2-r0.

@Zoey2936
Copy link
Contributor Author

Zoey2936 commented Apr 12, 2023

thanks!

richard-signal pushed a commit to signalapp/coturn that referenced this pull request Oct 18, 2023
@Zoey2936 @tyranron @richard-signal
Upgrade Alpine 3.17 version in Docker image (coturn#1156)
3ce4337 
Co-authored-by: Kai Ren <[email protected]>
This was referenced Mar 19, 2024
Closed
Closed
@chenrui333 chenrui333 mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@Zoey2936 Zoey2936

Labels

docker Docker image related enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zoey2936 @eakraly @tyranron