-
Notifications
You must be signed in to change notification settings - Fork 293
Fixes #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit variadic constructors can be marked explicit as they can have one or more arguments
# Conflicts: # cpplint.pyx
There are occasions where you would like to copy documentation from an overloaded function on a single doxygen comment line: /// @copydoc Func(const int lot, const int of, const int parameters, const int that, const int go, const int over, const int line, const int length) This shouldn't be a line length error as doxygen doesn't parse the command correctly if you split it over two lines
There are occasions where you would like to copy documentation from an overloaded function on a single doxygen comment line: /// @copydoc Func(const int lot, const int of, const int parameters, const int that, const int go, const int over, const int line, const int length) This shouldn't be a line length error as doxygen doesn't parse the command correctly if you split it over two lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @theandrewdavis, this is somewhat embarassing, I had forgotten that you took cpplint maintenance over, and over the last few weeks I continued working on my cpplint fork.
I merged several PRs that people did on the original google styleguide repo, and made some fixes of my own. Some discussion here: tkruse/cpplint#19
No harm done, I guess, I'll just make PRs against your repo.
This PR are the things I had already merged into my fork, I can split them up into smaller PRs if you feel unsure about some of the commits.