Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update changes at google to r456 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Conversation

tkruse
Copy link
Contributor

@tkruse tkruse commented May 19, 2016

Hi,

it seems cpplint is not quite dead at google, they just do the development in their SVN repo, which is not public anymore (which is a real pity), and they kind of ignore pull requests at github for cpplint.

This PR merges google/styleguide#130
into master, and to make things a bit more obvious, I merged with the latest gh_pages branch.

I think this should better be merged before #11, #12, #13, #14, #15, #16
because the google development should take precedence. Then we'd have to rebase.

zettca and others added 23 commits November 27, 2015 18:12
Most significant updates:
* Casting (for arithmetic types, maybe use {}s)
* Namespaces
* Aliases
The paragraph was renamed
…rmat-readme

Reflow README to 80 characters & add license logo
Replaced "less" with "fewer"
The claim that multi-line strings are not part of ECMAScript is
false. See the "LineContinuation" production in:
http://www.ecma-international.org/ecma-262/5.1/#sec-7.8.4.

Removed the false claim.
Replaced HTTP where HTTPS was available
Reverted XML namespace name changes
456 - Tweak lint to sometimes allow { on line following array initialization.
455 - Recognize more types.
454 - Try a bit harder to detect templated types.
453 - Changed error message wording on build/storage_class to be less ambiguous.
452 - Recognize more types to silence false positives for brace warnings.
451 - <skipped>
450 - <skipped>
449 - Ignore whitespace/tab for Linux Kernel files.
448 - Remove some more false positive lint warnings for int64{n}.
447 - Just one warning message for line length is enough, don't need two.
446 - Allow braced conversions to int16, uint64, etc. per the style guide.
445 - Fixed handling of backslash escapes for checking whether a "//" is quoted.
444 - Reduced dependency on hardcoded .cc extension.
443 - Disable single-arg constructor checks by default, since ClangTidy has the
      same check. We could just delete the check entirely, but it's slightly
      useful in places that can't run ClangTidy.
442 - Fix matching of macro names in CheckTrailingSemicolon to include digits.
441 - Deleted checks:
      - All checks for RValue references.
      - Spacing check around boolean &&, because those look like RValue
        references.
      A huge amount of code and effort were dedicated to tell RValue
      references apart from boolean expressions, and to differentiate
      allowed versus banned RValue references. But we still get regular
      false positives from this one check. Rather than making the check
      more complex than what it already is, it seemed safer to just delete
      it altogether for now, and have a different process for catching
      RValue references.
440 - Add rule to cpplint to throw error on empty if statement bodies without
      else clauses. If statement bodies with comments are not considered empty.
439 - Allow spaces before closing brace of namespace block so that namespaces
      inside of macro definitions (where the entire macro definition is
      indented) are not treated as errors.
438 - cpplint: fix a false positive on `new const int(x)`.
437 - Only check for function length when current line is inside a function.
436 - cpplint: Catch static `std::string` instances as well as those written as
      `string`. Previously users would sometimes work around the lint warning by
      changing their code to even worse code by adding the "std::" prefix.
435 - cpplint: Be a little smarter about warning on indentation.
434 - cpplint: Remove false positives on some functions returning string const&.
433 - cpplint: improve diagnostics of global/static string objects.
432 - Allow non-const reference parameters for iostream based types.
431 - Better handling of raw strings inside comments.
430 - <noop>
429 - <skipped>
428 - <skipped>
427 - Add support to CHECK_NOTNULL when checking if a member variable is
      initialized with itself.
426 - Allow suppressing specific warnings in C headers.
425 - Allow spaces before parens for inline assembly.
424 - Remove lint checks for {EXPECT,ASSERT}_.*_M.
423 - Allow comment lines of more than 80 characters if they contain a single
      "word" (without any spaces).
422 - cpplint: Warn on inclusion of C++14 headers.
421 - cpplint: recognize <shared_mutex> as a standard library header.
420 - Add <scoped_allocator> to cpplint's list of C++ standard headers.
419 - Add cpplint check for tr1/ headers. We removed the nanny guards for these
418 - <skipped>
417 - Update the styleguide and cpplint to allow unnamed parameters
416 - Remove the rule explicitly banning non-default move operations.
415 - Remove the check for explicit multi arg constructors
414 - Include clarity of lambda default captures in "pros" section, mention
      of capturing `this` and lambdas which escape the current scope in "cons".
      Soften the ban on default captures to a preference, with admonition against
      using them for capturing `this` or when they will escape the current scope.
      This is a fairly straightforward change with a brief inclusion
      of 2 problematic cases for implicit capture. As this is the style
      guide, I'm not sure how much more detail is appropriate.
413 - Fixed a bug by making regex in CleanseRawStrings match multiple raw strings
      on a single line in left-to-right order.
412 - Fixed false positive for classes derived using decltype()
411 - <skipped>
410 - Recognize '1LL<<20' as numeric and don't flag it for spacing.
Remove trailing whitespaces and a false claim in the JavaScript Style Guide
# Conflicts:
#	LICENSE
#	README.md
#	Rguide.xml
#	angularjs-google-style.html
#	cppguide.html
#	cpplint.py
#	cpplint_unittest.py
#	docguide/best_practices.md
#	docguide/style.md
#	htmlcssguide.xml
#	javaguide.html
#	javascriptguide.xml
#	jsoncstyleguide.xml
#	lispguide.xml
#	objcguide.xml
#	pyguide.html
#	shell.xml
#	styleguide.xsl
#	vimscriptfull.xml
#	vimscriptguide.xml
#	xmlstyle.html
@tkruse
Copy link
Contributor Author

tkruse commented May 19, 2016

note you can ignore the contents of all the commits except for mine and 01e4723, because they deal with upstream changes to files that are deleted on this fork.

@tkruse
Copy link
Contributor Author

tkruse commented May 19, 2016

Also note that google has removed certain rules, so it has relaxed some style checks. Maybe that should be reflected in the released cpplint version number.

@thomasjo
Copy link

thomasjo commented Jul 1, 2016

Is there anything I can help out with to get this shipping? I'm vendoring this version of cpplint.py right now, but it'd be awesome to be able to fall back to PyPI again.

@tkruse
Copy link
Contributor Author

tkruse commented Jul 1, 2016

Hm, I pinged @theandrewdavis by mail...

@theandrewdavis
Copy link
Contributor

I believe this was superseded by #22 which is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.