Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crmne/ruby_llm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.7.0
Choose a base ref
...
head repository: crmne/ruby_llm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.7.1
Choose a head ref
  • 9 commits
  • 21 files changed
  • 2 contributors

Commits on Sep 10, 2025

  1. Bust README gem cache

    crmne authored Sep 10, 2025
    Configuration menu
    Copy the full SHA
    3d57b9e View commit details
    Browse the repository at this point in the history
  2. Fix namespaced model table names in upgrade generator (#398)

    ## Description
    
    This PR fixes issue #397 where the upgrade generator produces invalid
    table names for namespaced models.
    
    ## Problem
    
    When using custom model names with namespaces (like `Assistant::Chat`,
    `Assistant::Message`, etc.) and running the upgrade generator:
    
    ```bash
    rails g ruby_llm:upgrade_to_v1_7 chat:Assistant::Chat message:Assistant::Message
    ```
    
    The migration would generate invalid table names like `:assistant/chats`
    instead of `:assistant_chats`.
    
    ## Solution
    
    The issue was that the generator was using `.tableize` which produces
    forward slashes for namespaced models. This has been fixed by using
    `.underscore.pluralize.tr('/', '_')` which properly converts namespaced
    model names to valid table names.
    
    ### Changes:
    - Added `table_name_for` helper method that correctly handles namespaced
    models
    - Added helper methods for each model type (`chat_table_name`,
    `message_table_name`, etc.)
    - Updated migration template to use the new helper methods instead of
    `.tableize`
    
    ## Testing
    
    Tested with namespaced models to confirm:
    - `Assistant::Chat` → `assistant_chats` ✓
    - `Assistant::Message` → `assistant_messages` ✓
    - `Assistant::ToolCall` → `assistant_tool_calls` ✓
    - `Assistant::Model` → `assistant_models` ✓
    
    Regular models continue to work as expected:
    - `Chat` → `chats` ✓
    - `Message` → `messages` ✓
    
    Fixes #397
    willcosgrove authored Sep 10, 2025
    Configuration menu
    Copy the full SHA
    ad036e1 View commit details
    Browse the repository at this point in the history
  3. Reorganize generators to follow Rails conventions

    - Move each generator into its own subdirectory
    - Update source paths to work from new locations
    - Add table_name_for helper to handle namespaced models
    - Fix chat_ui generator to properly handle namespaced model table names
    - Place private methods in conventional location at end of class
    crmne committed Sep 10, 2025
    Configuration menu
    Copy the full SHA
    c811173 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecc8afa View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2025

  1. Improve upgrade generator and add troubleshooting docs

    - Fix instance variable usage in migration template
    - Fix generators when using namespaced models
    - Simplify upgrade instructions to point to migration guide
    - Add troubleshooting section for acts_as_model error from issue #400
    - Add warning about acts_as_model error directly in generator output
    - Create initializer if missing during upgrade
    - Use consistent helper methods across install and upgrade generators
    crmne committed Sep 11, 2025
    Configuration menu
    Copy the full SHA
    552732c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a5ad13 View commit details
    Browse the repository at this point in the history
  3. Add automatic acts_as declaration updates to upgrade generator

    - Upgrade generator now automatically rewrites existing models' acts_as declarations
    - Updates Chat, Message, and ToolCall models to include proper model associations
    - Create shared GeneratorHelpers module to DRY up generator code
    - Add automatic namespace module creation with table_name_prefix for namespaced models
    - Fix template paths in upgrade generator to use source_paths correctly
    - Update docs to highlight automatic acts_as updates as key feature
    - Delete implementation detail tests that check source code strings
    crmne committed Sep 11, 2025
    Configuration menu
    Copy the full SHA
    939d532 View commit details
    Browse the repository at this point in the history
  4. Bump version to 1.7.1

    crmne committed Sep 11, 2025
    Configuration menu
    Copy the full SHA
    cd3dfc5 View commit details
    Browse the repository at this point in the history
  5. Updated appraisal gemfiles

    crmne committed Sep 11, 2025
    Configuration menu
    Copy the full SHA
    6ee02d0 View commit details
    Browse the repository at this point in the history
Loading