ENH,BUG: Allow strides without mem, fix empty byte-bounds#9453
Merged
Conversation
It ended up a bit more than I thought... on the plus side: * Speed up creation slightly by avoiding use of Python functions for the bounds calculation. * Use cython side helper for byte-bounds, which also fixes a bug (NumPy 2 moved this function, but a different thing.) * Allow allocation if `strides=` is passed, closes cupygh-7818 (Limited to what NumPy does, whether thought through or not...) In the end the speed up might be the most wortwhile thing here...
leofang
approved these changes
Oct 29, 2025
Member
|
/test mini |
Member
Author
|
Hmmmm, lots of CI timeouts, just chance or real risk of a slowdown? |
Member
It's fixed by #9460. |
Member
|
/test mini |
Member
|
I restarted some CIs that resulted in a timeout and confirmed that all tests passed. |
asi1024
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It ended up a bit more than I thought... on the plus side:
strides=is passed, closesndarrayconstructor behavior mismatches whenstridesis given #7818 (Limited to what NumPy does, whether thought through or not...)All of these are very small improvements, but since I started, let's finish it I guess.