Revert typo fix in cupy/_core/include/cupy/complex/complex.h#9460
Merged
Conversation
cupy/_core/include/cupy/complex/complex.h
Member
Author
|
/test skip |
leofang
approved these changes
Oct 30, 2025
Member
|
Note: We reverted #9454 partially because by touching the internal (Thrust) headers it invalidated the kernel cache and caused all CI pipelines to time out due to re-compilation. We missed this during code review. In general we want to be very cautious about cache invalidation because the CI costs real money. I will revert this PR when I start working on #9333. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #9454