Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimize and fix for www.baidu.com #13255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Optimize and fix for www.baidu.com #13255

merged 4 commits into from
Sep 21, 2024

Conversation

Yersmagit
Copy link
Contributor

Optimize and fix for www.baidu.com

@Yersmagit
Copy link
Contributor Author

Yersmagit commented Sep 17, 2024

Before After
1 image image
2 image image

Fix bugs
Copy link
Contributor Author

@Yersmagit Yersmagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 24/09/17 21:10(UTC+8) : Fix bugs.

@Myshor
Copy link
Collaborator

Myshor commented Sep 20, 2024

As I can see you use static colors in fixes but it breaks light scheming in Dark Reader.

For example: https://www.baidu.com/s?wd=%E5%BA%86%E7%A5%9D%E4%BA%BA%E6%B0%91%E6%94%BF%E5%8D%8F%E6%88%90%E7%AB%8B75%E5%91%A8%E5%B9%B4%E5%A4%A7%E4%BC%9A&sa=fyb_n_homepage&rsv_dl=fyb_n_homepage&from=super&cl=3&tn=baidutop10&fr=top1000&rsv_idx=2&hisfilter=1

obraz

To fix this you should use ${color} where the color is the original color to invert(100%) and hue-rotate(180deg).

So example how to use this... Let's pretend you use some color now like #334455 instead if you want to have same effect you use ${#AABBCC}

So you make negative and change sides for RED and BLUE.

Copy link
Collaborator

@Myshor Myshor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix colors to work fine with light and dark scheming.

Fix colors to work fine with light and dark scheming
Copy link
Contributor Author

@Yersmagit Yersmagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 24/09/21 18:30(UTC+8) : Fix colors to work fine with light and dark scheming.

image

Fix bugs
@Yersmagit
Copy link
Contributor Author

Update 24/09/21 23:10(UTC+8) : Fix bugs.

@Myshor Myshor merged commit e9e01b8 into darkreader:main Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants