Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add editorconfig #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Add editorconfig #24

merged 1 commit into from
Jun 16, 2025

Conversation

NeilGirdhar
Copy link
Contributor

No description provided.

@NeilGirdhar NeilGirdhar force-pushed the editorconfig branch 2 times, most recently from 10c77e5 to 7b6f22e Compare June 14, 2025 18:35
@NeilGirdhar NeilGirdhar changed the title Editorconfig Add editorconfig Jun 14, 2025
nstarman
nstarman previously approved these changes Jun 15, 2025
jorenham
jorenham previously approved these changes Jun 16, 2025
@jorenham
Copy link
Member

feel free to ignore my nitpickings

@NeilGirdhar NeilGirdhar dismissed stale reviews from jorenham and nstarman via 8ac6e08 June 16, 2025 00:06
@NeilGirdhar
Copy link
Contributor Author

On the contrary, I appreciate them πŸ˜†

@jorenham
Copy link
Member

@nstarman I changed the repo settings so that new commits won't dismiss review approvals anymore

@jorenham jorenham added the πŸ§‘β€πŸ’» dev Improve developer experience. label Jun 16, 2025
@NeilGirdhar
Copy link
Contributor Author

Do you need me to squash and update the commit message?

@jorenham
Copy link
Member

Do you need me to squash and update the commit message?

nah there's a button for that

@jorenham jorenham enabled auto-merge (squash) June 16, 2025 00:13
@jorenham jorenham disabled auto-merge June 16, 2025 00:13
@jorenham
Copy link
Member

Hmm it requires signed commits, maybe we should disable that @nstarman ?

@nstarman
Copy link
Collaborator

Or people should sign commits πŸ˜†

@NeilGirdhar
Copy link
Contributor Author

I'll sign and squash

@NeilGirdhar NeilGirdhar force-pushed the editorconfig branch 2 times, most recently from 7311f43 to 036726f Compare June 16, 2025 00:19
@NeilGirdhar
Copy link
Contributor Author

(I added yaml to the main section since it was missing)

@jorenham
Copy link
Member

the commit isn't verified

@NeilGirdhar NeilGirdhar force-pushed the editorconfig branch 2 times, most recently from 95cb79e to 7ff3b22 Compare June 16, 2025 00:48
@NeilGirdhar
Copy link
Contributor Author

Is something messed up with the code coverage check?

@jorenham
Copy link
Member

CI also fails on main, see #26

@jorenham jorenham merged commit 59e8f61 into data-apis:main Jun 16, 2025
1 of 11 checks passed
@jorenham
Copy link
Member

Thanks @NeilGirdhar !

@lucascolley
Copy link
Member

I recently updated the wording of SPEC 8 to say:

It is also strongly recommended that release managers use signed commits, so that each release corresponds to a verified commit. Note that it can be difficult to enforce this via GitHub permissions without requiring all contributors to also sign their commits, which may be undesirable for many projects.

It used to recommend requiring signed commits via GitHub permissions, but we figured that this was untenable for array-api-extra given the current options available via GitHub.

@NeilGirdhar NeilGirdhar deleted the editorconfig branch June 16, 2025 13:56
@jorenham
Copy link
Member

noob question: what could go wrong if commits aren't signed?

@lucascolley
Copy link
Member

other people can use your email in the Author field of a commit and it will look like it came from you. Unless your commits are always signed, in which case the commit will show as unverified (unless the other person has compromised your GPG keys or messed around in your GitHub security settings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ§‘β€πŸ’» dev Improve developer experience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants