-
Notifications
You must be signed in to change notification settings - Fork 4
Add editorconfig #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editorconfig #24
Conversation
10c77e5
to
7b6f22e
Compare
feel free to ignore my nitpickings |
On the contrary, I appreciate them π |
@nstarman I changed the repo settings so that new commits won't dismiss review approvals anymore |
Do you need me to squash and update the commit message? |
nah there's a button for that |
Hmm it requires signed commits, maybe we should disable that @nstarman ? |
Or people should sign commits π |
I'll sign and squash |
7311f43
to
036726f
Compare
(I added yaml to the main section since it was missing) |
the commit isn't verified |
95cb79e
to
7ff3b22
Compare
7ff3b22
to
79fbe29
Compare
Is something messed up with the code coverage check? |
CI also fails on main, see #26 |
Thanks @NeilGirdhar ! |
I recently updated the wording of SPEC 8 to say:
It used to recommend requiring signed commits via GitHub permissions, but we figured that this was untenable for array-api-extra given the current options available via GitHub. |
noob question: what could go wrong if commits aren't signed? |
other people can use your email in the Author field of a commit and it will look like it came from you. Unless your commits are always signed, in which case the commit will show as unverified (unless the other person has compromised your GPG keys or messed around in your GitHub security settings). |
No description provided.