Property to allow composing file previews #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new configuration property, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant MetadataBitstreamRestRepository
participant ConfigurationService
Client->>MetadataBitstreamRestRepository: Request bitstream metadata
MetadataBitstreamRestRepository->>ConfigurationService: Get create.file-preview.on-item-page-load
ConfigurationService-->>MetadataBitstreamRestRepository: Return true/false
alt create.file-preview.on-item-page-load is true
MetadataBitstreamRestRepository->>MetadataBitstreamRestRepository: Generate and store preview content
else create.file-preview.on-item-page-load is false
MetadataBitstreamRestRepository->>MetadataBitstreamRestRepository: Skip preview content generation
end
MetadataBitstreamRestRepository-->>Client: Return response
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
|
@milanmajchrak Maybe I’ll change the message, because currently the file preview is not being generated at all — it’s not that it's generating unsuccessfully, they don't need to contact administrator. |
milanmajchrak
requested changes
Apr 15, 2025
...ver-webapp/src/main/java/org/dspace/app/rest/repository/MetadataBitstreamRestRepository.java
Outdated
Show resolved
Hide resolved
milanmajchrak
approved these changes
Apr 15, 2025
vidiecan
approved these changes
Apr 15, 2025
milanmajchrak
added a commit
that referenced
this pull request
Apr 22, 2025
* Enhanced file preview feature - Run file preview as authenticated user (#936), Property to allow composing file previews (#935), Do not create temp file during generating preview (#921) * Use the handle url instead of the items url with the UUID (#938) * Items file metadata not correctly updated (#940) * Remove duplicate dependency element with identical content (warnings in build) * Anonymous users should be able to use shortener * Fixed internal server error, when context.commit() was called multiple times in search request * Catch DSpaceBadRequestException rather than BadRequestException * Fixed security issue for downloading file with non anonymous license * Fixed Clarinuserregistration nullpoint exception (#941)
kosarko
added a commit
to ufal/clarin-dspace
that referenced
this pull request
May 5, 2025
pulling changes from latest (lindat-2025.04.14600125143) dataquest release This contains the following changes: - UFAL/Run file preview as authenticated user (dataquest-dev#936) - Property to allow composing file previews (dataquest-dev#935) - File preview is not loaded properly for big zip file (dataquest-dev#921) - UFAL/Clarinuserregistration nullpoint exception (dataquest-dev#941) - UFAL/Use the handle url instead of the items url with the UUID (dataquest-dev#938) - UFAL/Items file metadata not correctly updated (dataquest-dev#940) - Synchronize ufal and dataquest main branches (dataquest-dev#939)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
We want to prevent users from triggering file preview generation when opening an item if a specific configuration property is not enabled. Allowing this behavior can lead to issues, especially when items contain large files—generating previews may take too long, and opening the same item multiple times could trigger concurrent preview generation processes before the first one has completed.
Summary by CodeRabbit