UFAL/Items file metadata not correctly updated #940
Conversation
…led after the bitstream was updated, so that items bitstream metadata wasn't correctly updated.
WalkthroughThe changes reorganize when and how the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BitstreamService
participant BundleService
participant ClarinItemService
User->>BitstreamService: delete(context, bitstream)
BitstreamService->>BitstreamService: Mark bitstream as deleted
BitstreamService->>BitstreamService: Update bitstream
loop For each bundle
BitstreamService->>BundleService: Remove bitstream from bundle
end
BitstreamService->>ClarinItemService: updateItemFilesMetadata(context, bitstream)
sequenceDiagram
participant User
participant BundleService
participant ClarinItemService
User->>BundleService: removeBitstream(context, bundle, bitstream)
BundleService->>BundleService: Remove bitstream from bundle
alt owningItem is not null
BundleService->>BundleService: Update owningItem last modified
BundleService->>BundleService: Save owningItem
end
BundleService->>ClarinItemService: updateItemFilesMetadata(context, owningItem, bundle)
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.31.1)dspace-server-webapp/src/test/java/org/dspace/app/rest/BitstreamRestRepositoryIT.javaTip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…has.files` metadata was updated correctly.
* Enhanced file preview feature - Run file preview as authenticated user (#936), Property to allow composing file previews (#935), Do not create temp file during generating preview (#921) * Use the handle url instead of the items url with the UUID (#938) * Items file metadata not correctly updated (#940) * Remove duplicate dependency element with identical content (warnings in build) * Anonymous users should be able to use shortener * Fixed internal server error, when context.commit() was called multiple times in search request * Catch DSpaceBadRequestException rather than BadRequestException * Fixed security issue for downloading file with non anonymous license * Fixed Clarinuserregistration nullpoint exception (#941)
pulling changes from latest (lindat-2025.04.14600125143) dataquest release This contains the following changes: - UFAL/Run file preview as authenticated user (dataquest-dev#936) - Property to allow composing file previews (dataquest-dev#935) - File preview is not loaded properly for big zip file (dataquest-dev#921) - UFAL/Clarinuserregistration nullpoint exception (dataquest-dev#941) - UFAL/Use the handle url instead of the items url with the UUID (dataquest-dev#938) - UFAL/Items file metadata not correctly updated (dataquest-dev#940) - Synchronize ufal and dataquest main branches (dataquest-dev#939)
Problem description
This issue causes that the file preview spinner was still loading where there weren't any file.
The issue: dataquest-dev/dspace-angular#833
Summary by CodeRabbit