-
Notifications
You must be signed in to change notification settings - Fork 6
Add multiple ci choice #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
python_seed/template/module/tox.ini
Outdated
@@ -19,7 +19,7 @@ ignore_missing_imports = True | |||
include_trailing_comma = True | |||
multi_line_output = 3 | |||
line_length = 90 | |||
known_first_party = python_seed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 bad merge on my side 🤦
- run: | ||
name: run tox | ||
command: ~/.local/bin/tox No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need review of this and test cc @CiaranEvans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you like me to test it @vincentsarago?
Is this repo meant to be a template that you can choose when making a new repo on Github or do you check it out and rename stuff?
Only way I could test it at the mo is create my own repo and chuck this in? I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this repo meant to be a template that you can choose when making a new repo on Github or do you check it out and rename stuff?
It's a CLI that create brand new project with the correct name
# Create a project
$ pyseed create awesomepythonproject
# List files created
$ ls -1 awesomepythonproject
.pre-commit-config.yaml
README.md
awesomepythonproject/
requirements-dev.txt
requirements.txt
setup.py
tests/
tox.ini
This PR adds an option for adding a CI config (either github or circleci). This is the first time I write github action so I'm not sure what I'm doing ;-)
Let me try it on this repo directly anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, how do I install it for use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now you have to clone the repo but it should be one pypi later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's all pretty sensible at the mo, I'll use it in a dummy repo and see!
Though this will publish for every push to any branch right now (I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this will publish for every push to any branch right now (I think)
publish should only run on tags if: contains(github.ref, 'tags')
and if tag == python version
- name: Check git tag vs. version
# We Only deploy to PyPi if github tag match the python version
run: |
VERSION=$(python setup.py --version)
if [ "$VERSION" = "$RELEASE_VERSION" ]; then exit 0; else exit 3; fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying it for this repo over #12
GitHub actions
…seed into addMultipleCI
closes #7