Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Aug 21, 2020

closes #7

@vincentsarago vincentsarago changed the base branch from master to version1 August 21, 2020 02:58
@@ -19,7 +19,7 @@ ignore_missing_imports = True
include_trailing_comma = True
multi_line_output = 3
line_length = 90
known_first_party = python_seed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 bad merge on my side 🤦

- run:
name: run tox
command: ~/.local/bin/tox No newline at end of file
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need review of this and test cc @CiaranEvans

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you like me to test it @vincentsarago?

Is this repo meant to be a template that you can choose when making a new repo on Github or do you check it out and rename stuff?

Only way I could test it at the mo is create my own repo and chuck this in? I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this repo meant to be a template that you can choose when making a new repo on Github or do you check it out and rename stuff?

It's a CLI that create brand new project with the correct name

# Create a project
$ pyseed create awesomepythonproject

# List files created
$ ls -1 awesomepythonproject
.pre-commit-config.yaml
README.md
awesomepythonproject/
requirements-dev.txt
requirements.txt
setup.py
tests/
tox.ini

This PR adds an option for adding a CI config (either github or circleci). This is the first time I write github action so I'm not sure what I'm doing ;-)

Let me try it on this repo directly anyway

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, how do I install it for use?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now you have to clone the repo but it should be one pypi later today.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks :D

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's all pretty sensible at the mo, I'll use it in a dummy repo and see!

Though this will publish for every push to any branch right now (I think)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though this will publish for every push to any branch right now (I think)

publish should only run on tags if: contains(github.ref, 'tags') and if tag == python version

      - name: Check git tag vs. version
        # We Only deploy to PyPi if github tag match the python version
        run: |
            VERSION=$(python setup.py --version)
            if [ "$VERSION" = "$RELEASE_VERSION" ]; then exit 0; else exit 3; fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying it for this repo over #12

@vincentsarago vincentsarago marked this pull request as ready for review August 21, 2020 16:35
@vincentsarago vincentsarago merged commit 9f384d7 into version1 Aug 21, 2020
@vincentsarago vincentsarago deleted the addMultipleCI branch August 21, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants