Closed
Conversation
Contributor
|
Why not switch to go modules? |
Author
|
@ericchiang I'll look into that. Thanks for the tip. |
Contributor
|
FYI, as part of our build we vendor "main" packages. I had to add the following file to trick // +build vendor
package main
// This file exists to trick "go mod vendor" to include "main" packages.
// It is not expected to build, the build tag above is only to prevent this
// file from being included in builds.
import (
_ "github.com/golang/protobuf/protoc-gen-go"
_ "golang.org/x/lint/golint"
)
func main() {} |
Author
|
Thanks, all! Closing this PR in favor of pursuing Go modules. See #1365. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for ideas on how to improve this PR until it's acceptable for merge. I would really like to see dex adopt the dep over glide.
Some caveats:
Gopkg.tomla list of subpackages we actually want, as we do with subpackage lists inglide.yaml. We could probably edit theGopkg.lockfile manually but that seems like a bad idea.Gopkg.tomlwas initially the result of runningdep initand letting dep try to migrate from glide. I had to changeconstrainttooverridein a couple of places to keepdepfrom throwing errors about pinning those transitive dependencies.Gopkg.toml. I think this is becausedepdidn't detect those packages were in use.glideisn't explicit about transitive dependency pinning butdepis (see[[override]]stanzas). We can definitely force re-inclusion of those dropped packages (seerequiredproperty in dep docs), butmakeworks just fine, so I'm not sure we need them.See: https://golang.github.io/dep/docs/Gopkg.toml.html
Note: There are 3 commits in this PR to separate config changes from delete/modified vendor files from new vendor files.