Migrate to go modules#1365
Conversation
|
@ericchiang Please see my question in the comment above. I'm eager to complete this PR. |
😄 I'd consider it a workaround. But this this fine. 🎉 Thanks for doing this, very nice to get up to speed with the ecosystem changes 👍 |
Can we call the file |
|
Workaround fixed the build. Thanks! |
|
Thanks! @josdotso per our docs, can you squash this PR into two commits? One with the regular file changes, and one with the vendor changes? https://github.com/dexidp/dex/blob/master/Documentation/dev-dependencies.md |
|
We can update that doc separately. |
|
Thanks @ericchiang. Does it look better now? |
ericchiang
left a comment
There was a problem hiding this comment.
lgtm!
Please submit a followup to the vendor documentation.
Migrate to go modules
This is a follow up to #1364 where
go modwas suggested as a betterglidereplacement thandep. I'll close #1364 in a few minutes in favor of this PR.Notes:
go.modas were inglide.yamlbecause it's not yet clear to me if these will be automatically dropped bygo mod.go moddoesn't seem to have an option for pruning non-go files.Makefileto replaceglidecalls withgo depcalls.TODO:
hackworkaround :) suggested by @ericchiang to enable vendoring main packages.main.gobe the right place?