Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate to go modules#1365

Merged
ericchiang merged 2 commits into
masterfrom
unknown repository
Dec 3, 2018
Merged

Migrate to go modules#1365
ericchiang merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 28, 2018

This is a follow up to #1364 where go mod was suggested as a better glide replacement than dep. I'll close #1364 in a few minutes in favor of this PR.

Notes:

  • I didn't make verbose comments in go.mod as were in glide.yaml because it's not yet clear to me if these will be automatically dropped by go mod.
  • go mod doesn't seem to have an option for pruning non-go files.
  • Updated Makefile to replace glide calls with go dep calls.

TODO:

  • Implement the hack workaround :) suggested by @ericchiang to enable vendoring main packages.
  • Fix the CI build when it probably breaks due to my first pass at this.

@ghost ghost mentioned this pull request Nov 28, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 30, 2018

@ericchiang Please see my question in the comment above. I'm eager to complete this PR.

@srenatus
Copy link
Copy Markdown
Contributor

srenatus commented Dec 1, 2018

Implement the hack suggested by...

😄 I'd consider it a workaround. But this this fine.

🎉 Thanks for doing this, very nice to get up to speed with the ecosystem changes 👍

@ericchiang
Copy link
Copy Markdown
Contributor

Question on that: Where should I write out the file you defined in #1364, @ericchiang? Would a top level main.go be the right place?

Can we call the file vendor.go?

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 3, 2018

Workaround fixed the build. Thanks!

@ericchiang
Copy link
Copy Markdown
Contributor

Thanks! @josdotso per our docs, can you squash this PR into two commits? One with the regular file changes, and one with the vendor changes?

*: remove glide and add Go module files
vendor: make revendor

https://github.com/dexidp/dex/blob/master/Documentation/dev-dependencies.md

@ericchiang
Copy link
Copy Markdown
Contributor

We can update that doc separately.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 3, 2018

Thanks @ericchiang. Does it look better now?

Copy link
Copy Markdown
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Please submit a followup to the vendor documentation.

@ericchiang ericchiang merged commit 8a47970 into dexidp:master Dec 3, 2018
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants