pkce in oauthlib 3.1.0 #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1374
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1360
💛 - Coveralls |
auvipy
approved these changes
Apr 9, 2020
|
@auvipy please enforce our PR requirements check boxes not checked: @dulmandakh not in AUTHORS as far as I can see. Credit(blame:-) where credit is due. |
|
ohh damn! |
Closed
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
OAuthLib landed PKCE support in 3.1.0 version via oauthlib/oauthlib#671. Therefore there is no need for work-around in django-oauth-toolkit.
Docs where failing due to m2r lacks compatibility with sphinx 3.x, so had to specify sphinx version to be lower than 3.
Maybe we need a new release with this change.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS