Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Postfix: add smtpd_data_restrictions = reject_unauth_pipelining #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
georglauterbach merged 5 commits into from
Jan 4, 2024
Merged

Postfix: add smtpd_data_restrictions = reject_unauth_pipelining #3744

georglauterbach merged 5 commits into from
Jan 4, 2024

Conversation

@georglauterbach
Copy link
Member

@georglauterbach georglauterbach commented Jan 3, 2024 •
edited
Loading

Description

See #3741

Fixes #3741

Type of change

  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@georglauterbach georglauterbach added service/postfix area/configuration (file) kind/update Update an existing feature, configuration file or the documentation labels Jan 3, 2024
@georglauterbach georglauterbach added this to the v14.0.0 milestone Jan 3, 2024
@georglauterbach georglauterbach self-assigned this Jan 3, 2024
@georglauterbach
Copy link
Member Author

georglauterbach commented Jan 3, 2024

Okay, tests fail as expected; wherever we use nc,

@polarathene
Copy link
Member

polarathene commented Jan 3, 2024

tests fail as expected; wherever we use nc

No worries, this change isn't a priority 👍

We could probably relax configuration for those affected tests as a workaround with postfix-main.cf, which should work.

polarathene
polarathene reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may work.

polarathene
polarathene requested changes Jan 3, 2024
View reviewed changes
@polarathene
Copy link
Member

polarathene commented Jan 3, 2024 •
edited
Loading

Tests pass now. Just restore the Amavis config line + changelog entry and this should be good to go 🚀

There is an existing changelog line for the SMTP smuggling fix that is related to this change. Although we didn't try the adding trust in our previous attempt so it may not matter 🤷‍♂️ (the IPv6 concern would now also apply though)

@georglauterbach georglauterbach added the meta/feature freeze On hold due to upcoming release process label Jan 4, 2024
casperklein
casperklein previously approved these changes Jan 4, 2024
View reviewed changes
polarathene
polarathene requested changes Jan 4, 2024
View reviewed changes
@polarathene polarathene mentioned this pull request Jan 4, 2024
Merged
4 tasks
@georglauterbach georglauterbach merged commit bf69ef2 into master Jan 4, 2024
@georglauterbach georglauterbach deleted the postfix/pipelining branch January 4, 2024 21:13
@georglauterbach georglauterbach modified the milestones: v14.0.0, v13.2.0 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@casperklein casperklein casperklein left review comments

Assignees

@georglauterbach georglauterbach

Labels

area/configuration (file) kind/update Update an existing feature, configuration file or the documentation meta/feature freeze On hold due to upcoming release process service/postfix

Projects

None yet

Milestone

v13.2.0

Development

Successfully merging this pull request may close these issues.

[TODO]: Add smtpd_data_restrictions = reject_unauth_pipelining to main.cf

4 participants

@georglauterbach @polarathene @casperklein