Conversation
Member
|
Should this target |
greg0ire
approved these changes
Apr 10, 2021
Member
|
I don't see a reason for bringing this back tbh. What's the reasoning behind this? |
Member
Author
|
@alcaeus the reason is that it still works on 7.1, DBAL 2.x still supports 7.1 and ORM also can support this because only this holds it back. Edit: All tooling supports 7.1 as well, PHPUnit, Psalm, phpcs and our coding standard. |
alcaeus
requested changes
Apr 11, 2021
Member
alcaeus
left a comment
There was a problem hiding this comment.
Absolutely not from my end: people can use version 1.3 if they need to run on 7.1. If you want them to be able to use the new api, introduce 7.1 support to 1.4.
Member
Author
|
Replaced by #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code still works on 7.1, no need to restrict it.