Conversation
Member
|
The PHPStan workflow seems to be missing from this branch, let's copy it? |
Member
|
Please extract the other changes (updating dependencies) to a separate PR. This PR should be merged into 3.x without applying the change, while the other stuff can be used in 3.x as well. If you're back porting this from 3, don't: 1.4 isn't really supported anymore and just provides a compatibility layer. |
Member
Author
|
@alcaeus i wish that were possible, but doctrine/coding-standard and the 0.11 phpstan plugins did not work on 7.1, their newer versions however do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #185
Code still works on 7.1 and there is no need to tighten the constraint.
Also updated the coding standard to 8.0 and phpstan to 0.12 and made the code compliant to both. Moved .travis to Github actions.