[2.4] Documenting interface methods (based on entity manager)#1191
Conversation
|
Hello, thank you for creating this pull request. However did not open it on the "master" Please open the pull request again for the "master" branch and close Nevertheless I have opened a Jira ticket for this Pull Request to track this http://www.doctrine-project.org/jira/browse/DDC-3409 We use Jira to track the state of pull requests and the versions they got |
|
BTW, this PR won't be closed by me, because of "one exception" in contributing rules. This undocumented interface such be treated as a bug. |
|
@mvar any reason why this should be backported in 2.4? |
|
@Ocramius the main reason is that this is needed for autocomplete as I've mentioned before. And because Doctrine 2.5 won't be released soon, this should be backported to 2.4. Guys, you are doing great job here. Please let community to use this library with joy :) |
|
@mvar just checked and saw that indeed the commits are the same. Merging. |
[2.4] Documenting interface methods (based on entity manager)
|
Thank you @Ocramius |
This PR follows #870 and my comments on it.
I think these changes are MUST for the stable release. Especially when Doctrine is used together with such high quality framework like Symfony.