Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documenting interface methods (based on entity manager)#870

Merged
Ocramius merged 3 commits into
doctrine:masterfrom
lcobucci:master
Dec 10, 2013
Merged

Documenting interface methods (based on entity manager)#870
Ocramius merged 3 commits into
doctrine:masterfrom
lcobucci:master

Conversation

@lcobucci
Copy link
Copy Markdown
Member

No description provided.

@doctrinebot
Copy link
Copy Markdown

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2846

We use Jira to track the state of pull requests and the versions they got
included in.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the FQCN

@Ocramius
Copy link
Copy Markdown
Member

Also: if these docblocks are extracted from the EntityManager, can we get rid of them in the implementation by using {@inheritDoc}?

@lcobucci
Copy link
Copy Markdown
Member Author

Perfect @Ocramius, I'll do that changes.

@lcobucci
Copy link
Copy Markdown
Member Author

@Ocramius, I'll add the {@inheritDoc} to methods from ObjectManager, is it ok?

@Ocramius
Copy link
Copy Markdown
Member

@lcobucci should be ok if they are 100% the same

@lcobucci
Copy link
Copy Markdown
Member Author

Done ;)

Ocramius added a commit that referenced this pull request Dec 10, 2013
Documenting interface methods (based on entity manager)
@Ocramius Ocramius merged commit 2cccb3c into doctrine:master Dec 10, 2013
@mvar
Copy link
Copy Markdown

mvar commented Oct 27, 2014

@Ocramius could you please merge this to branch 2.4 also? Almost one year passed but there is no stable release with these changes yet. Any release actually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants