-
Notifications
You must be signed in to change notification settings - Fork 2
Error on nullable dependencies discordant with base class #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Signed-off-by: zio-mitch <[email protected]>
@zio-mitch It's likely that you will encounter inconsistencies between the tutorial and the current Dotkernel API codebase. |
@alexmerlin I know actually I'm following the tutorial step by step, do you prefer that I will continue opening PRs without Issues, or just stop cause you are actually doing a major rewrite? |
Thanks for doing this, it's always helpful having another pair of 👀 taking a look at our code/docs. Actually, we are in the middle of shipping the next major version, so the tutorial will definitely need some refactoring. |
The above-mentioned major version does not yet have a deadline, there are a couple more features that we plan to implement, so in the meantime, the docs need to stay up-to-date, so if you find more issues, we appreciate your time fixing them. |
Signed-off-by: zio-mitch <[email protected]>
Fixes: #88 invalid Abstract handler construction declaration
Bug Report
Book module example:
HalResponseFactory::class and ResourceGenerator::class are now nullable in Api\App\Handler\AbstractHandler implementation.
Summary
Documentation provide erroneus example code
Current behavior
Following documentation example the user will write non working code.
How to reproduce
Follow the documentation example.
Expected behavior
Following documentation example the user will produce working code.
The text was updated successfully, but these errors were encountered: