Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Error on nullable dependencies discordant with base class #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zio-mitch opened this issue Mar 11, 2025 · 4 comments · Fixed by #89
Closed

Error on nullable dependencies discordant with base class #88

zio-mitch opened this issue Mar 11, 2025 · 4 comments · Fixed by #89

Comments

@zio-mitch
Copy link
Contributor

Bug Report

Book module example:

HalResponseFactory::class and ResourceGenerator::class are now nullable in Api\App\Handler\AbstractHandler implementation.

Q A
Version(s) 5

Summary

Documentation provide erroneus example code

Current behavior

Following documentation example the user will write non working code.

How to reproduce

Follow the documentation example.

Expected behavior

Following documentation example the user will produce working code.

zio-mitch added a commit to zio-mitch/api-documentation that referenced this issue Mar 11, 2025
zio-mitch added a commit to zio-mitch/api-documentation that referenced this issue Mar 11, 2025
@alexmerlin
Copy link
Member

@zio-mitch It's likely that you will encounter inconsistencies between the tutorial and the current Dotkernel API codebase.
These inconsistencies are the result of the tutorial being lagged behind while the Dotkernel API codebase being in continuous evolution.
We will prioritize refreshing the tutorial to avoid these inconsistencies.

@zio-mitch
Copy link
Contributor Author

zio-mitch commented Mar 11, 2025

@alexmerlin I know actually I'm following the tutorial step by step, do you prefer that I will continue opening PRs without Issues, or just stop cause you are actually doing a major rewrite?
Let me know if I can help.

@alexmerlin
Copy link
Member

@alexmerlin I know actually I'm following the tutorial step by step, do you prefer that I will continue opening PRs without Issues, or just stop cause you are actually doing a major rewrite? Let me know if I can help.

Thanks for doing this, it's always helpful having another pair of 👀 taking a look at our code/docs.

Actually, we are in the middle of shipping the next major version, so the tutorial will definitely need some refactoring.

@alexmerlin
Copy link
Member

The above-mentioned major version does not yet have a deadline, there are a couple more features that we plan to implement, so in the meantime, the docs need to stay up-to-date, so if you find more issues, we appreciate your time fixing them.

zio-mitch added a commit to zio-mitch/api-documentation that referenced this issue Mar 12, 2025
zio-mitch added a commit to zio-mitch/api-documentation that referenced this issue Mar 12, 2025
alexmerlin added a commit that referenced this issue Mar 12, 2025
Fixes: #88 invalid Abstract handler construction declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants