Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed properties override when publishing an update in external service #10822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Fixed properties override when publishing an update in external service #10822

merged 1 commit into from
Aug 4, 2025

Conversation

MermaidIsla
Copy link
Contributor

Description

This PR fixes an issue where properties of an external resource were being overridden upon publishing an update with state Running.

Fixes #10680

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 3, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 3, 2025
@MermaidIsla
Copy link
Contributor Author

@dotnet-policy-service agree

@MermaidIsla
Copy link
Contributor Author

Not exactly sure how to create a test for this. I had a few ideas about checking whether the Properties was completely changed but I thought in certain cases that might be necessary to do so it feels like I would break more than prevent.

@davidfowl davidfowl enabled auto-merge (squash) August 4, 2025 00:05
@davidfowl
Copy link
Member

/backport to release/9.4.1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Started backporting to release/9.4.1: https://github.com/dotnet/aspire/actions/runs/16710923513

@davidfowl
Copy link
Member

/backport to release/9.4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

@davidfowl an error occurred while backporting to "release/9.4.1", please check the run log for details!

Error: The specified backport target branch "release/9.4.1" wasn't found in the repo.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16710925580

@github-actions github-actions bot mentioned this pull request Aug 4, 2025
Merged
@davidfowl davidfowl merged commit ced7327 into dotnet:main Aug 4, 2025
551 of 553 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.5 milestone Aug 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.

Some parent relationships are not visible in the dashboard
2 participants
@MermaidIsla @davidfowl