Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[main] Source code updates from dotnet/diagnostics #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 7, 2025
Merged

[main] Source code updates from dotnet/diagnostics #2205

merged 9 commits into from
Sep 7, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/diagnostics

@akoeplinger
Add Microsoft.Extensions.Logging.Abstractions to Version.Details.xml
a05271d 
It's referenced by Microsoft.Diagnostics.NETCore.Client.csproj so source-build needs to be able to override it
@akoeplinger
Add runtime repository reference to diagnostics project
9c117ca
@akoeplinger akoeplinger requested review from a team as code owners September 1, 2025 15:20
ViktorHofer
ViktorHofer reviewed Sep 2, 2025
View reviewed changes
@akoeplinger
Copy link
Member

@dotnet/source-build thoughts on whether we should go with this approach (adding the repo dependency and V.D.xml entries for Microsoft.Extensions.Logging.Abstractions) or adding the package to SBRP?

@ellahathaway
Copy link
Member

@dotnet/source-build thoughts on whether we should go with this approach (adding the repo dependency and V.D.xml entries for Microsoft.Extensions.Logging.Abstractions) or adding the package to SBRP?

Does the package need to be pinned to 9.0.8? If so, it needs to be added to SBRP.

@akoeplinger
Copy link
Member

It was upgraded as part of dotnet/diagnostics#5545, I don't know if it's strictly necessary for it to be on that version.

@akoeplinger
Copy link
Member

I talked to @steveisok and the upgrade was necessary to fix some build compliance issues. I think it will be easier if we just add this to SBRP so opened dotnet/source-build-reference-packages#1359

@akoeplinger akoeplinger merged commit 9d24e13 into main Sep 7, 2025
16 checks passed
@akoeplinger akoeplinger deleted the darc-main-4fba14ca-83f6-4cda-97ad-202740be8952 branch September 7, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akoeplinger @ellahathaway @ViktorHofer