Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 5, 2025

This PR adds the Microsoft.Extensions.Logging.Abstractions 9.0.8 reference package to support .NET source builds that require this version.

Changes Made

Added the following reference packages using the generate.sh script:

Primary Package

  • Microsoft.Extensions.Logging.Abstractions 9.0.8
    • Target frameworks: net8.0, net9.0, netstandard2.0
    • Includes all required logging abstractions APIs
    • Proper dependency configuration per target framework

Dependencies (automatically generated)

  • Microsoft.Extensions.DependencyInjection.Abstractions 9.0.8
  • System.Diagnostics.DiagnosticSource 9.0.8
  • Microsoft.Bcl.AsyncInterfaces 9.0.8

Package Structure

The generated package follows the established pattern for 9.0.x reference packages:

src/referencePackages/src/microsoft.extensions.logging.abstractions/9.0.8/
├── Microsoft.Extensions.Logging.Abstractions.9.0.8.csproj
├── lib/
│   ├── net8.0/Microsoft.Extensions.Logging.Abstractions.cs
│   ├── net9.0/Microsoft.Extensions.Logging.Abstractions.cs
│   └── netstandard2.0/Microsoft.Extensions.Logging.Abstractions.cs
└── microsoft.extensions.logging.abstractions.nuspec

Bug Fix Applied

Fixed a compilation error in System.Diagnostics.DiagnosticSource 9.0.8 for netstandard2.0 by adding Customizations.props that includes:

  • IsExternalInit.cs - Required for C# init-only properties in netstandard2.0
  • RequiredModifierAttributes.cs - Supporting attributes

Verification

  • ✅ All target frameworks compile successfully
  • ✅ Assembly version information is correct (9.0.8)
  • ✅ Package structure matches existing 9.0.x packages
  • ✅ Dependencies are properly configured per target framework
  • ✅ Generated reference assemblies follow expected patterns
  • ✅ IsExternalInit error resolved for netstandard2.0 builds

This package enables source builds that depend on Microsoft.Extensions.Logging.Abstractions 9.0.8 without requiring prebuilt binaries.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Add reference packages for Microsoft.Extensions.Logging.Abstractions 9.0.8 Add reference packages for Microsoft.Extensions.Logging.Abstractions 9.0.8 Sep 5, 2025
@Copilot Copilot AI requested a review from akoeplinger September 5, 2025 13:48
Copilot finished work on behalf of akoeplinger September 5, 2025 13:48
@akoeplinger
Copy link
Member

@copilot to fix the IsExternalInit error in the netstandard2.0 build of System.Diagnostics.DiagnosticSource you can add this:

Copy link
Contributor Author

Copilot AI commented Sep 5, 2025

@copilot to fix the IsExternalInit error in the netstandard2.0 build of System.Diagnostics.DiagnosticSource you can add this: https://github.com/dotnet/source-build-reference-packages/blob/25c18c250f2...

Fixed the IsExternalInit error by adding Customizations.props to System.Diagnostics.DiagnosticSource 9.0.8, which includes both IsExternalInit.cs and RequiredModifierAttributes.cs from the common source directory. The netstandard2.0 build now compiles successfully. (507be76)

Copilot finished work on behalf of akoeplinger September 5, 2025 14:05
@akoeplinger akoeplinger marked this pull request as ready for review September 5, 2025 14:22
@akoeplinger akoeplinger requested a review from a team as a code owner September 5, 2025 14:22
@MichaelSimons MichaelSimons merged commit c8e7069 into main Sep 5, 2025
4 checks passed
@MichaelSimons MichaelSimons deleted the copilot/fix-5337ea7a-7aa1-4368-9b22-6a48e10b534d branch September 5, 2025 14:58
@akoeplinger
Copy link
Member

/backport to release/10.0

Copy link
Contributor

github-actions bot commented Sep 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants