-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Filter out JS interop APIs for compiler #8392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs Build status updates of commit 724949d:
|
File | Status | Preview URL | Details |
---|---|---|---|
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback 1.xml) |
View | Details | |
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback 1.xml) |
View | Details | |
xml/_filter.xml | ✅Succeeded |
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback
1.xml)
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.JavaScript.JSMarshalerArgument'.
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback
1.xml)
- Line 0, Column 0: [Warning: xref-not-found]
Cross reference not found: 'System.Runtime.InteropServices.JavaScript.JSMarshalerArgument'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
@pavelsavara Should the following types also be non-editor browsable? JSMarshalerArgument.ArgumentToJSCallback Delegate |
Yes, I thought they are hidden by the fact they are nested type in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @gewarren
This LGTM. Let's once you and @pavelsavara are happy.
@pavelsavara Yes I tested this and IntelliSense still shows the nested type even if the parent type is |
Thanks for checking, I created dotnet/runtime#75800 to address it on main and will ask for backport. |
The warnings will go away once we import the RC 2 APIs, so merging this now. |
See #8390 (comment).
Filtering reference: https://review.docs.microsoft.com/en-us/help/onboard/admin/reference/dotnet/filtering-apis?branch=main#filter-apis-with-certain-attributes