Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 15, 2022

@gewarren gewarren requested a review from a team as a code owner September 15, 2022 20:16
@ghost ghost assigned gewarren Sep 15, 2022
@opbld32
Copy link

opbld32 commented Sep 15, 2022

Docs Build status updates of commit 724949d:

⚠️ Validation status: warnings

File Status Preview URL Details
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml) ⚠️Warning View Details
[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml) ⚠️Warning View Details
xml/_filter.xml ✅Succeeded

[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback1.xml)

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.JavaScript.JSMarshalerArgument'.

[xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml](https://github.com/gewarren/dotnet-api-docs/blob/browsable-filter/xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback1.xml)

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Runtime.InteropServices.JavaScript.JSMarshalerArgument'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

@pavelsavara
Copy link
Member

ArgumentToJSCallback Delegate

Yes, I thought they are hidden by the fact they are nested type in JSMarshalerArgument which is EditorBrowsableState.Never.
So we need to fix it on the API ?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @gewarren

This LGTM. Let's :shipit: once you and @pavelsavara are happy.

@gewarren
Copy link
Contributor Author

ArgumentToJSCallback Delegate

Yes, I thought they are hidden by the fact they are nested type in JSMarshalerArgument which is EditorBrowsableState.Never. So we need to fix it on the API ?

@pavelsavara Yes I tested this and IntelliSense still shows the nested type even if the parent type is EditorBrowsableState.Never. Do you want to submit a PR to hide the nested types?

@pavelsavara
Copy link
Member

@pavelsavara Yes I tested this and IntelliSense still shows the nested type even if the parent type is EditorBrowsableState.Never. Do you want to submit a PR to hide the nested types?

Thanks for checking, I created dotnet/runtime#75800 to address it on main and will ask for backport.

@gewarren
Copy link
Contributor Author

The warnings will go away once we import the RC 2 APIs, so merging this now.

@gewarren gewarren merged commit a34fe82 into dotnet:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants