Fix rootfs dir #781
Merged
Fix rootfs dir #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthalman the build is failing during I believe the kitware signing keys have been updated, but we are still using a cached base image with an older signing key, the one obtained here: How would I go about updating the base images? (As a longer-term solution, it looks like there is a package that will keep signing keys updated - kitware-archive-keyring, mentioned here: https://apt.kitware.com/). |
|
@sbomer - If you make an arbitrary change to the base Dockerfile, it will trigger it to get rebuilt. Then you can revert your change. It's based off commit SHA, so it should still rebuild even after you revert your change. |
This reverts commit 5b95d32.
This reverts commit 7e69adf.
akoeplinger
approved these changes
Jan 27, 2023
mthalman
approved these changes
Jan 27, 2023
This reverts commit 9ccff47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rootfs dir for the images added in #754, to be consistent with the existing images.
I looked for a way to extract this into a single variable in the Dockerfile. The only way I found was to use ENV, but that would persist the environment variable into the created image - and I want to avoid polluting the image's environment.