Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jan 20, 2023

This uses new cross-build images, added in dotnet/dotnet-buildtools-prereqs-docker#754, that target Ubuntu 16.04. The initial change is only for Linux arm64, to match what we plan to do in .NET 7 (in #80866). I'm making the change in 8.0 to get validation of the PGO instrumentation, which happens in official builds, but not in PR jobs.

The new images were published here: dotnet/versions@33968c3

@ghost
Copy link

ghost commented Jan 20, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This uses new cross-build images, added in dotnet/dotnet-buildtools-prereqs-docker#754, that target Ubuntu 16.04. The initial change is only for Linux arm64, to match what we plan to do in .NET 7 (in #80866). I'm making the change in 8.0 to get validation of the PGO instrumentation, which happens in official builds, but not in PR jobs.

The new images were published here: dotnet/versions@33968c3

Author: sbomer
Assignees: sbomer
Labels:

area-Infrastructure-libraries

Milestone: -

@sbomer sbomer requested a review from janvorli January 20, 2023 18:31
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-cross-arm64
env:
ROOTFS_DIR: /crossrootfs/arm64
ROOTFS_DIR: /crossrootfs
Copy link
Member

@am11 am11 Jan 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This convention is documented in number of places. Lets not introduce a break because everyone using these prereq images outside this CI (for years) remember the default location of ROOTFS_DIR.

eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/arm
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/armv6
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/arm64
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/arm
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/arm64
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/x86
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/s390x
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/ppc64le
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/x64
eng/pipelines/common/templates/pipeline-with-resources.yml:        ROOTFS_DIR: /crossrootfs/armel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I updated the build images, the change to the rootfs dir was unintentional. Fixing it in dotnet/dotnet-buildtools-prereqs-docker#781.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update dotnet/runtime once the fix is rolled out.

@sbomer sbomer requested a review from marek-safar as a code owner January 26, 2023 22:48
@sbomer
Copy link
Member Author

sbomer commented Jan 26, 2023

@akoeplinger @lambdageek @directhex I am updating the MonoAotOffsetsPrefix to what it was before #68561, for arm64. This fixes a LLVM AOT build failure due to 7 not being available on the new build images.

@sbomer
Copy link
Member Author

sbomer commented Jan 27, 2023

Mono test failure is #81123.

@sbomer sbomer merged commit 71f7f84 into dotnet:main Jan 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2023
@sbomer sbomer deleted the glibcVersion80 branch November 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants