Templated indicator view - improvements #25642
Merged
+207
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 6, 2024
| for (int i = 0; i < 3; i++) | ||
| App.Click("AddItemButton"); | ||
|
|
||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Snapshots already available in the latest build.
Example, iOS:
|
|
||
| [Test] | ||
| [Category(UITestCategories.IndicatorView)] | ||
| public void IndicatorWithTemplateShouldBeVisible() |
There was a problem hiding this comment.
Test seems to crash on Windows:
The app was expected to be running still, investigate as possible crash
TearDown : The app was expected to be running still, investigate as possible crash
There was a problem hiding this comment.
I think there's something wrong with the UI test with the Carousel view with the data template on Windows. Probably we will have the same crash without any changes. Like we do in this PR: #24776
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
e7af6bc to
228fba5
Compare
jfversluis
approved these changes
Jun 4, 2025
PureWeen
added a commit
that referenced
this pull request
Jun 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate
rmarinho
pushed a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR addresses several issues with the IndicatorView when using a DataTemplate, particularly around collection updates. Specifically, it aims to resolve the following bugs:
Indicator disappears on empty collection: When all items are removed, the indicators disappear as expected. However, upon adding items back, the indicators do not reappear.
Last indicator not rendering: In certain cases, adding new elements to the collection does not render the final indicator properly.
Incorrect visual state for the current page indicator: When an item is removed from the collection, the visual state of the current page indicator becomes incorrect.
This pull request, alongside PR #21980, which addresses the rendering and sizing issues of IndicatorView with DataTemplate, should resolve all known issues with IndicatorView in this context. If any issues remain, I’ll be disappointed—but I’ll make sure to address them.
NotReAppearing.mov
IsSelectedNotWorkingCorrectly.mov
LastItemNotAppearing.mov
Working.mov
Issues Fixed
Fixes #25598