asking terminal for dimensions during every frame is expensive #11504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AR-May
approved these changes
Feb 26, 2025
baronfel
reviewed
Feb 26, 2025
MichalPavlik
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11160
Context
While profiling some of Eric's PRs and one of my experiments, I've noticed following:
Terminal width/height are behind a lock and repeated access is quite expensive.
Changes Made
I've set it so that the update is happening only once every ~second or so. This makes the cost negligible.
Note that this appears to be ~1.5% CPU time saved on the main node, which is the one under heaviest load due to IPC with all the other nodes.
Testing
None, this should be non-disruptive change.
Notes
Refresh frequency is up to discussion. Making it twice a second should be fine as well.