Merge 'dotnet/main' into ParamsCollections #72042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Merge pull request dotnet#71412 from vibeeshan025/main
…-release/dev17.10 Merge release/dev17.9 to release/dev17.10
…-release/dev17.10 Merge release/dev17.9 to release/dev17.10
…o-main Merge release/dev17.10 to main
…o-main Merge release/dev17.10 to main
Provide overloads to avoid unnecessary boxing
Disable autoBraceSurround on 17.9 P2 tests
…oslyn into keepProjectCone
…oftJsonVersion Fix NewtonsoftJsonVersion problem
* Build bootstrap compiler in separate phase This moves the infrastructure for building a bootstrap compiler into a separate phase. The reason for this is to facilitate better performance investigations. Having the bootstrap compiler build inside our build makes it basically impossible to profile using a freshly built compiler to build our repo. Having separate phases mean that locally I can now - build the bootstrap compiler - start the profiler - rebuild roslyn Overall I think it's also just a bit cleaner this way. * yml * yml * cleanup * fixes * more * bootstrap change * yml * more * more
Break out the IsFrozen flag to be an aspect of CompilationTrackerState.
Fix crash with convert to record
|
@dotnet/roslyn-compiler Need a sign-off on a merge from 'main' into ParamsCollections. This is a fast-forward merge. |
|
@dotnet/roslyn-compiler Need a sign-off on a merge from 'main' into ParamsCollections. This is a fast-forward merge. |
I see some tests updated in 25414ee though - are they part of fast-forward merge? |
No, they are not. |
|
One test was adjusted and one new test was added. The change in behavior is expected in the feature branch. |
jcouv
approved these changes
Feb 12, 2024
333fred
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.