Bulk-suppress linker warnings during library builds #40106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jul 30, 2020
| @@ -18,6 +18,7 @@ | |||
| <Platforms>x64;x86;arm;arm64</Platforms> | |||
|
|
|||
| <ILLinkTrimAssembly>true</ILLinkTrimAssembly> | |||
| <ILLinkTrimAssemblyVerbose>false</ILLinkTrimAssemblyVerbose> | |||
There was a problem hiding this comment.
CoreLib is the largest and most important library that we got. It does not sound right to disable the analysis for it.
There was a problem hiding this comment.
We don't need this property, we should get rid of it. Instead, we need to suppress these ILLinker warnings for all projects for now.
Here's the overall plan:
- (this PR) Suppress the ILLinker reflection warnings in bulk.
mono/linkermakes the change to enable warnings by default (it only warns on--verbosetoday)- We can then take the new ILLinker in
dotnet/runtimebecause the warnings are suppressed
~ The above is needed for .NET 5. The below is optional for .NET 5, or can be done early in .NET 6
- We add a new step in the build that runs the ILLinker on the whole shared framework. This doesn't have any warnings suppressed in bulk. Instead, we suppress individual warnings using a baseline file.
- This stops new warnings from being introduced
~ The below is out of scope for .NET 5 and will be done at a later date
- We start working down the baseline file assembly-by-assembly by fixing the ILLinker warnings for real.
ViktorHofer
reviewed
Jul 30, 2020
eerhardt
reviewed
Jul 30, 2020
eerhardt
approved these changes
Jul 30, 2020
marek-safar
reviewed
Jul 31, 2020
Comment on lines
+219
to
+228
| <!-- suppress warnings with the following codes: | ||
| IL2006: The generic parameter 'T' from A with dynamically accessed member kinds B is passed into the generic parameter | ||
| 'T' from 'System.Lazy<T>' which requires dynamically accessed member kinds 'PublicParameterlessConstructor' | ||
| IL2008: Could not find type A specified in resource B | ||
| IL2009: Could not find method A in type B specified in resource C | ||
| IL2012: Could not find field A in type B specified in resource C | ||
| IL2025: Duplicate preserve of A in B | ||
| IL2026: Calling A which has B can break functionality when trimming application code. The target method might be removed. | ||
| IL2035: Unresolved assembly A in DynamicDependencyAttribute on B | ||
| IL2041: The DynamicallyAccessedMembersAttribute is only allowed on method parameters, return value or generic parameters. |
There was a problem hiding this comment.
Why are we suppressing all these warnings without any explanation or tracking item? It seems to me that issues like IL2025 should be trivial to fix
There was a problem hiding this comment.
The plan is to do this to be able to enable warnings in the linker. Once we have the XML based suppressions ready the plan is to remove this and replace it with the generated XML files.
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Enable verbose linker output and bulk-suppress warnings * Suppress ILLinker warnings for now, so ILLinker can enable warnings by default Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #38033.