Remove char[] allocations from RegistryKey and List copy to Array #78737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bKeyCount & ValueCount.
… rare cases where there are more or less elements during the loop).
|
Tagging subscribers to this area: @dotnet/area-microsoft-win32 Issue DetailsThis is a rewrote of closed PR #78558 - because of the merge #77996. Replace List by string[] to avoid List.ToArray() copy (it must handle rare cases where there are more or less elements during the loop).
|
stephentoub
reviewed
Dec 1, 2022
src/libraries/Microsoft.Win32.Registry/src/Microsoft/Win32/RegistryKey.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 1, 2022
src/libraries/Microsoft.Win32.Registry/src/Microsoft/Win32/RegistryKey.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrote of closed PR #78558 - because of the merge #77996.
Replace List by string[] to avoid List.ToArray() copy (it must handle rare cases where there are more or less elements during the loop).
Avoid redondant verification EnsureNotDisposed() already called by SubKeyCount & ValueCount.