Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove char[] allocations from RegistryKey and List copy to Array #78737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Remove char[] allocations from RegistryKey and List copy to Array #78737

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dac03ff
Avoid redondant verification EnsureNotDisposed() already called by Su…
Poppyto Nov 22, 2022
8e53fb0
Replace List by string[] to avoid List.ToArray() copy (it must handle…
Poppyto Nov 22, 2022
14fdd77
Apply suggestions from code review
stephentoub Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@stephentoub
stephentoub authored Dec 1, 2022
commit 14fdd77c93d189e4f1c28a17103f66e31e72e00a
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Win32.Registry/src/Microsoft/Win32/RegistryKey.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,6 @@ ref MemoryMarshal.GetReference(nameSpan),
switch (result)
{
case Interop.Errors.ERROR_SUCCESS:

if (cpt >= names.Length) // possible new item during loop
{
Array.Resize(ref names, names.Length * 2);
Expand All @@ -820,6 +819,7 @@ ref MemoryMarshal.GetReference(nameSpan),
names[cpt++] = new string(nameSpan.Slice(0, nameLength));
nameLength = nameSpan.Length;
break;

default:
// Throw the error
Win32Error(result, null);
Expand Down