Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jun 22, 2023

Contributes to unrooting ConfigurationBinder from the ASP.NET Goldilocks stage 2 showcase app - TodosApi.

FYI @DamianEdwards @eerhardt.

@layomia layomia added area-Extensions-Logging source-generator Indicates an issue with a source generator feature labels Jun 22, 2023
@layomia layomia added this to the 8.0.0 milestone Jun 22, 2023
@layomia layomia self-assigned this Jun 22, 2023
@ghost
Copy link

ghost commented Jun 22, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to unrooting ConfigurationBinder from the ASP.NET Goldilocks stage 2 showcase app - TodosApi.

FYI @DamianEdwards @eerhardt.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Logging, source-generator

Milestone: 8.0.0

@layomia
Copy link
Contributor Author

layomia commented Jun 22, 2023

@eerhardt @ericstj I know there's no functional difference, but do you reckon we should use the generator in place of #82254 & #82098? Upsides are having extra test coverage for the generator & that we wouldn't need custom logic if more config binding is needed in the future.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this doesn't change the Microsoft.Extensions.Logging.Configuration package dependencies it's good to go :shipit:

@ericstj
Copy link
Member

ericstj commented Jun 23, 2023

but do you reckon we should use the generator in place of #82254 & #82098

As we discussed offline - yes this is a good idea. You'll want to inspect the code diff when you do just to see that there's no significant perf or behavior diff in the generated code. As we discussed - best to do that in a separate PR.

@layomia layomia merged commit feb1fe2 into dotnet:main Jun 24, 2023
@layomia layomia deleted the binder-gen-rooting branch June 24, 2023 00:21
@ericstj
Copy link
Member

ericstj commented Jun 29, 2023

I was testing out ASP.NET stage1 app with the nightly preview 6 build. I picked up this fix by referencing the nightly Preview7 package and it reduced the size of the stage1 app by 643 KB. Nice!

9,056,256 webaot.exe // with fix
9,715,200 webaot.exe // without fix

@eerhardt
Copy link
Member

We are seeing it in the charts as well:

image

@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants