-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use config binding generator in Microsoft.Extensions.Logging.Configuration assembly #87935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-logging Issue DetailsContributes to unrooting FYI @DamianEdwards @eerhardt.
|
...osoft.Extensions.Logging.Configuration/src/Microsoft.Extensions.Logging.Configuration.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this doesn't change the Microsoft.Extensions.Logging.Configuration package dependencies it's good to go
As we discussed offline - yes this is a good idea. You'll want to inspect the code diff when you do just to see that there's no significant perf or behavior diff in the generated code. As we discussed - best to do that in a separate PR. |
src/libraries/Microsoft.Extensions.Logging.Configuration/src/LoggerFilterConfigureOptions.cs
Show resolved
Hide resolved
I was testing out ASP.NET stage1 app with the nightly preview 6 build. I picked up this fix by referencing the nightly Preview7 package and it reduced the size of the stage1 app by 643 KB. Nice!
|
Contributes to unrooting
ConfigurationBinder
from the ASP.NET Goldilocks stage 2 showcase app - TodosApi.FYI @DamianEdwards @eerhardt.