Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the cppcli tests by upgrading to preview 7 in stage 0 #42822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Aug 18, 2024
@marcpopMSFT
Copy link
Member Author

/backport to release/9.0.1xx-rc1

Copy link
Contributor

Started backporting to release/9.0.1xx-rc1: https://github.com/dotnet/sdk/actions/runs/10444465458

@marcpopMSFT
Copy link
Member Author

@jjonescz @jared to fix a windows sdk issue that was failing the cppcli tests, I upgraded to preview 7. This caused a bunch of failures as it triggered the torn toolset package to be downloaded for our tests (but it expected the -ci version of the package). I disabled using the torn toolset in our helix tests by changing the .cmd file to set the build with framework to false. However, that broke one of the tests we had for that.

I tried fixing it and failed so I went ahead and disabled so we could get unblocked but we'll want to figure out how to fix it later:
It_downloads_Microsoft_Net_Compilers_Toolset_Framework_when_MSBuild_is_torn

@lewing
Copy link
Member

lewing commented Aug 19, 2024

approving preemptively if this goes green since this was an infrastructure change that broke things

@marcpopMSFT marcpopMSFT enabled auto-merge August 19, 2024 01:35
@marcpopMSFT marcpopMSFT merged commit 9bdfba1 into release/9.0.1xx Aug 19, 2024
31 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-fixcppcli branch August 19, 2024 02:52
@marcpopMSFT
Copy link
Member Author

Following up on this @jjonescz @dsplaisted an alternative to disabling the roslyn package in our tests is to copy it to our nuget cache so the tests can find it. That would fully test this package more. It's probably worth filing an issue to do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants