-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix the cppcli tests by upgrading to preview 7 in stage 0 #42822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Try removing windowsforms from the not expected reference names
/backport to release/9.0.1xx-rc1 |
Started backporting to release/9.0.1xx-rc1: https://github.com/dotnet/sdk/actions/runs/10444465458 |
@jjonescz @jared to fix a windows sdk issue that was failing the cppcli tests, I upgraded to preview 7. This caused a bunch of failures as it triggered the torn toolset package to be downloaded for our tests (but it expected the -ci version of the package). I disabled using the torn toolset in our helix tests by changing the .cmd file to set the build with framework to false. However, that broke one of the tests we had for that. I tried fixing it and failed so I went ahead and disabled so we could get unblocked but we'll want to figure out how to fix it later: |
approving preemptively if this goes green since this was an infrastructure change that broke things |
Following up on this @jjonescz @dsplaisted an alternative to disabling the roslyn package in our tests is to copy it to our nuget cache so the tests can find it. That would fully test this package more. It's probably worth filing an issue to do that instead. |
No description provided.