Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dll detection in dotnet test #50926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

Fix dll detection in dotnet test #50926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9991d4d
Property with .dll should not offload test run to vstest.console.exe
nohwnd Sep 19, 2025
ece13b5
Merge branch 'release/10.0.1xx' into dll-fix
nohwnd Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Cli/dotnet/Commands/Test/VSTest/TestCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,16 @@ internal static int RunArtifactPostProcessingIfNeeded(string testSessionCorrelat

private static bool ContainsBuiltTestSources(string[] args)
{
foreach (string arg in args)
for (int i = 0; i < args.Length; i++)
Copy link
Member

@Youssef1313 Youssef1313 Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I run dotnet test --filter "Category=.dll"?
Is this going to incorrectly return true?

Copy link
Member Author

@nohwnd nohwnd Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely not, it needs better fix, but right now we need to unblock the merge in vstest.

{
if (!arg.StartsWith("-") &&
(arg.EndsWith(".dll", StringComparison.OrdinalIgnoreCase) || arg.EndsWith(".exe", StringComparison.OrdinalIgnoreCase)))
string arg = args[i];
if (arg.EndsWith(".dll", StringComparison.OrdinalIgnoreCase) || arg.EndsWith(".exe", StringComparison.OrdinalIgnoreCase))
{
var previousArg = i > 0 ? args[i - 1] : null;
if (previousArg != null && CommonOptions.PropertiesOption.Aliases.Contains(previousArg))
{
return false;
}
return true;
}
}
Expand Down
32 changes: 32 additions & 0 deletions test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,38 @@ public void ArgumentsEndWithDllOrExeShouldNotFail(string arg)
}
}


[Theory]
[InlineData("-p:ABC=C:\\my.dll")]
[InlineData("/p:ABC=C:\\my.dll")]
[InlineData("-property:ABC=C:\\my.dll")]
public void PropertiesEndingWithDotDllShouldNotFail(string property)
{
var testProjectDirectory = CopyAndRestoreVSTestDotNetCoreTestApp([]);

// Call test
// The test will complain about --property:VsTestUseMSBuildOutput=false but
// it is the .dll parameter that is causing this. It forces the command to offload work
// to vstest.console.exe directly, because it thinks there is some test .dll that we should run
// directly, rather than a project file.
// Vstest.console.exe will then complain just about the first unknown parameter.
CommandResult result = new DotnetTestCommand(Log, disableNewOutput: true)
.WithWorkingDirectory(testProjectDirectory)
.Execute(ConsoleLoggerOutputNormal.Concat([property]));

// Verify
if (!TestContext.IsLocalized())
{
result.StdOut.Should().Contain("Total tests: 2");
result.StdOut.Should().Contain("Passed: 1");
result.StdOut.Should().Contain("Failed: 1");
result.StdOut.Should().Contain("Passed VSTestPassTest");
result.StdOut.Should().Contain("Failed VSTestFailTest");
}

result.ExitCode.Should().Be(1);
}

private string CopyAndRestoreVSTestDotNetCoreTestApp(object[] parameters, [CallerMemberName] string callingMethod = "")
{
// Copy VSTestCore project in output directory of project dotnet-vstest.Tests
Expand Down
Loading