Move Microsoft.Windows.Compatibility into windowsdesktop #3516
Conversation
There was a problem hiding this comment.
Question - Is my PR obsolete now? dotnet/runtime#83557
I ask because of this:
Microsoft.Windows.Compatibility meta package needs to be moved into a higher layer as runtime can't depend on winforms' product dependencies
and because you explained to me via chat that we're going to build Microsoft.Windows.Compatibility all the time.
BTW there is a merge conflict in Versions.props.
|
Ah no, my PR is for 7.0. I assume that is still valid. Your change (and whatever upcoming changes we add to runtime) go into main. |
No. This change targets only the main branch. |
|
Yes, we need to add all those dependencies for coherency purposes only. This is because there is no way for coherency to guarantee a correct version without being in "strict" mode, and strict mode requires that if you say: "I depend on the version of X that Y has", that Y has a dependency on that version. |
Now that System.Drawing.Common is part of winforms, the Microsoft.Windows.Compatibility meta package needs to be moved into a higher layer as runtime can't depend on winforms' product dependencies. Moving TargetFramework property into the respective project files to allow this repository to have multi-targeting projects.
9e0acae to
73a6a91
Compare
Unblocks dotnet/windowsdesktop#3516 Microsoft.Windows.Compatibility is being migrated from runtime to windowsdesktop and depends on packages from dotnet/runtime. As there's already a subscription from runtime -> winforms, a new one can't be added directly between runtime -> windowsdesktop as that would cause coherency issues. Instead, we need to flow the dependencies through winforms and wpf.
* Add dependencies required by windowsdesktop Unblocks dotnet/windowsdesktop#3516 Microsoft.Windows.Compatibility is being migrated from runtime to windowsdesktop and depends on packages from dotnet/runtime. As there's already a subscription from runtime -> winforms, a new one can't be added directly between runtime -> windowsdesktop as that would cause coherency issues. Instead, we need to flow the dependencies through winforms and wpf. * Update Version.Details.xml * Remove Windows.Compatiblity dependency
Unblocks dotnet/windowsdesktop#3516 Microsoft.Windows.Compatibility is being migrated from runtime to windowsdesktop and depends on packages from dotnet/runtime. As there's already a subscription from runtime -> winforms, a new one can't be added directly between runtime -> windowsdesktop as that would cause coherency issues. Instead, we need to flow the dependencies through winforms and wpf.
Blocked by dotnet/wpf#7681
Now that System.Drawing.Common is part of winforms, the Microsoft.Windows.Compatibility meta package needs to be moved into a higher layer as runtime can't depend on winforms' product dependencies.
Moving the
TargetFrameworkproperty into the respective project files to allow this repository to have multi-targeting projects.Also updating the Traversal project which now avoids an unnecessary package dependency on the net45 reference assemblies.
cc @JeremyKuhne