-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Download): add FileName check #6568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds non-empty filename validation to both DownloadFromStream and DownloadFromUrl, removes obsolete .NET version directives in the stream download logic, and includes the missing System namespace import. Class diagram for updated Download component methodsclassDiagram
class DownloadOption {
+string FileName
+Stream FileStream
+string Url
}
class Download {
+Task DownloadFromStream(DownloadOption option)
+Task DownloadFromUrl(DownloadOption option)
}
Download --> DownloadOption: uses
Flow diagram for filename validation in download methodsflowchart TD
A[Start DownloadFromStream or DownloadFromUrl] --> B{Is FileName null or empty?}
B -- Yes --> C[Throw InvalidOperationException]
B -- No --> D[Proceed with download logic]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6568 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 719 719
Lines 31560 31566 +6
Branches 4450 4452 +2
===========================================
Hits 31560 31560
- Misses 0 4 +4
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6567
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enforce non-null FileName in Download component and remove obsolete NET5_0 conditional logic
Bug Fixes:
Enhancements: