Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 7, 2025

Link issues

fixes #6567

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enforce non-null FileName in Download component and remove obsolete NET5_0 conditional logic

Bug Fixes:

  • Throw InvalidOperationException when FileName is null or empty in DownloadFromStream
  • Throw InvalidOperationException when FileName is null or empty in DownloadFromUrl

Enhancements:

  • Remove NET5_0 conditional compilation from DownloadFromStream
  • Add System namespace import

@bb-auto bb-auto bot added the enhancement New feature or request label Aug 7, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds non-empty filename validation to both DownloadFromStream and DownloadFromUrl, removes obsolete .NET version directives in the stream download logic, and includes the missing System namespace import.

Class diagram for updated Download component methods

classDiagram
    class DownloadOption {
        +string FileName
        +Stream FileStream
        +string Url
    }
    class Download {
        +Task DownloadFromStream(DownloadOption option)
        +Task DownloadFromUrl(DownloadOption option)
    }
    Download --> DownloadOption: uses
Loading

Flow diagram for filename validation in download methods

flowchart TD
    A[Start DownloadFromStream or DownloadFromUrl] --> B{Is FileName null or empty?}
    B -- Yes --> C[Throw InvalidOperationException]
    B -- No --> D[Proceed with download logic]
Loading

File-Level Changes

Change Details Files
Import missing System namespace
  • Added "using System;" directive at the top of the file
src/BootstrapBlazor/Components/Download/Download.cs
Enforce FileName non-null and non-empty in download methods
  • Throw InvalidOperationException if option.FileName is null or empty in DownloadFromStream
  • Throw InvalidOperationException if option.FileName is null or empty in DownloadFromUrl
src/BootstrapBlazor/Components/Download/Download.cs
Remove outdated .NET conditional compilation for stream download
  • Deleted #if NET5_0 / #elif NET6_0_OR_GREATER blocks and associated await Task.CompletedTask
  • Always use DotNetStreamReference and InvokeVoidAsync unconditionally
src/BootstrapBlazor/Components/Download/Download.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6567 Add a check to ensure that the FileName property is not null or empty before proceeding with download operations in the Download component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 7, 2025
@ArgoZhang ArgoZhang merged commit b035658 into main Aug 7, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-download branch August 7, 2025 03:47
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.98%. Comparing base (3ddbf27) to head (5ecfeb4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/BootstrapBlazor/Components/Download/Download.cs 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #6568      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          719      719              
  Lines        31560    31566       +6     
  Branches      4450     4452       +2     
===========================================
  Hits         31560    31560              
- Misses           0        4       +4     
- Partials         0        2       +2     
Flag Coverage Δ
BB 99.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Download): add FileName check
1 participant